Config option - injecting document.domain #5974
Closed
+459
−1,012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection removal and reversion
jennifer-shehane
requested changes
Nov 4, 2024
cypress-documentation
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-documentation
|
| Branch Review |
config/inject-document-domain
|
| Run status |
|
| Run duration | 03m 21s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
279
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
10.89%
|
|
|---|---|
|
Untested elements
|
2227
|
|
Tested elements
|
3
|
Accessibility
95.68%
|
|
|---|---|
|
Failed rules
|
2 critical
5 serious
4 moderate
0 minor
|
|
Failed elements
|
530
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
2 tasks
AtofStryker
reviewed
Dec 20, 2024
| #### Known Incompatibilities | ||
|
|
||
| Setting this configuration value to `true` can cause the application you are testing | ||
| to behave in unexpected ways. This is especially true if a site your tests visit |
There was a problem hiding this comment.
there are implications if your site sets it, but there are also implications where the browser defaults the origin-agent-cluster into buckets, which can cause problems. I think this is also worth mentioning
Co-authored-by: Bill Glesias <bglesias@gmail.com>
…press-io/cypress-documentation into config/inject-document-domain
|
I have completely messed up this branch and don't even know how. 🙏🏻 Opening #6058 to replace it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(draft pr for work relating to cypress-io/cypress#29590)